netdev - RE: [EXT] Re: [PATCH v3 net-next 00/13] Add ethtool ntuple filters support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR18MB321233569BEE8D88940C425DA2E50@DM6PR18MB3212.namprd18.prod.outlook.com>
Date:   Sat, 14 Nov 2020 19:00:01 +0000
From:   Naveen Mamindlapalli <naveenm@...vell.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        "Linu Cherian" <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>
Subject: RE: [EXT] Re: [PATCH v3 net-next 00/13] Add ethtool ntuple filters
 support

Hi Saeed,
Thanks for the review.

> -----Original Message-----
> From: Saeed Mahameed <saeed@...nel.org>
> Sent: Friday, November 13, 2020 1:47 AM
> To: Naveen Mamindlapalli <naveenm@...vell.com>; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Cc: kuba@...nel.org; davem@...emloft.net; Sunil Kovvuri Goutham
> <sgoutham@...vell.com>; Linu Cherian <lcherian@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>; Jerin Jacob Kollanukkaran
> <jerinj@...vell.com>; Subbaraya Sundeep Bhatta <sbhatta@...vell.com>;
> Hariprasad Kelam <hkelam@...vell.com>
> Subject: [EXT] Re: [PATCH v3 net-next 00/13] Add ethtool ntuple filters support
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, 2020-11-11 at 12:43 +0530, Naveen Mamindlapalli wrote:
> > This patch series adds support for ethtool ntuple filters, unicast
> > address filtering, VLAN offload and SR-IOV ndo handlers. All of the
> > above features are based on the Admin Function(AF) driver support to
> > install and delete the low level MCAM entries. Each MCAM entry is
> > programmed with the packet fields to match and what actions to take if
> > the match succeeds. The PF driver requests AF driver to allocate set
> > of MCAM entries to be used to install the flows by that PF. The
> > entries will be freed when the PF driver is unloaded.
> >
> > * The patches 1 to 4 adds AF driver infrastructure to install and
> >   delete the low level MCAM flow entries.
> > * Patch 5 adds ethtool ntuple filter support.
> > * Patch 6 adds unicast MAC address filtering.
> > * Patch 7 adds support for dumping the MCAM entries via debugfs.
> > * Patches 8 to 10 adds support for VLAN offload.
> > * Patch 10 to 11 adds support for SR-IOV ndo handlers.
> > * Patch 12 adds support to read the MCAM entries.
> >
> > Misc:
> > * Removed redundant mailbox NIX_RXVLAN_ALLOC.
> >
> > Change-log:
> > v3:
> > - Fixed Saeed's review comments on v2.
> > 	- Fixed modifying the netdev->flags from driver.
> > 	- Fixed modifying the netdev features and hw_features after
> > register_netdev.
> > 	- Removed unwanted ndo_features_check callback.
> > v2:
> > - Fixed the sparse issues reported by Jakub.
> >
> 
> Reviewed-by: Saeed Mahameed <saeedm@...dia.com>