netdev - Re: [PATCHv2 net] sctp: change to hold/put transport for proto_unreach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 14 Nov 2020 11:58:28 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>,
        linux-sctp@...r.kernel.org, davem@...emloft.net,
        Neil Horman <nhorman@...driver.com>,
        Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCHv2 net] sctp: change to hold/put transport for
 proto_unreach_timer

On Sat, 14 Nov 2020 10:40:23 -0300 Marcelo Ricardo Leitner wrote:
> On Sat, Nov 14, 2020 at 01:22:53PM +0800, Xin Long wrote:
> > A call trace was found in Hangbin's Codenomicon testing with debug kernel:
> >   
> ...
> > 
> > So fix it by holding/putting transport instead for proto_unreach_timer
> > in transport, just like other timers in transport.
> > 
> > v1->v2:
> >   - Also use sctp_transport_put() for the "out_unlock:" path in
> >     sctp_generate_proto_unreach_event(), as Marcelo noticed.
> > 
> > Fixes: 50b5d6ad6382 ("sctp: Fix a race between ICMP protocol unreachable and connect()")
> > Reported-by: Hangbin Liu <liuhangbin@...il.com>
> > Signed-off-by: Xin Long <lucien.xin@...il.com>  
> 
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Applied, thanks!