netdev - Re: [PATCH net-next] lib8390: Use eth_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <044e6281-5f1e-9b4b-e283-0f37583a16ff@gmail.com>
Date:   Sat, 14 Nov 2020 13:03:20 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Armin Wolf <W_Armin@....de>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH net-next] lib8390: Use eth_skb_pad()



On 11/12/2020 8:31 AM, Armin Wolf wrote:
> Use eth_skb_pad() instead of a custom padding solution
> and replace associated variables with skb->* expressions.
> 
> Signed-off-by: Armin Wolf <W_Armin@....de>
> ---

[snip]

> @@ -407,8 +404,8 @@ static netdev_tx_t __ei_start_xmit(struct sk_buff *skb,
>  	spin_unlock(&ei_local->page_lock);
>  	enable_irq_lockdep_irqrestore(dev->irq, &flags);
>  	skb_tx_timestamp(skb);
> +	dev->stats.tx_bytes += skb->len;
>  	dev_consume_skb_any(skb);
> -	dev->stats.tx_bytes += send_length;

There is nothing wrong here with the existing code and you could avoid
an use-after-free if not careful, I would personally keep the existing
code which appears to be just fine.
-- 
Florian