netdev - Re: [PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201114005633.axcb6sc5qddycsuy@skbuf>
Date:   Sat, 14 Nov 2020 02:56:33 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Tobias Waldekranz <tobias@...dekranz.com>, davem@...emloft.net,
        andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and
 ethertype DSA taggers

On Fri, Nov 13, 2020 at 04:27:09PM -0800, Jakub Kicinski wrote:
> On Wed, 11 Nov 2020 14:11:52 +0100 Tobias Waldekranz wrote:
> > Ethertype DSA encodes exactly the same information in the DSA tag as
> > the non-ethertype variety. So refactor out the common parts and reuse
> > them for both protocols.
> >
> > This is ensures tag parsing and generation is always consistent across
> > all mv88e6xxx chips.
> >
> > While we are at it, explicitly deal with all possible CPU codes on
> > receive, making sure to set offload_fwd_mark as appropriate.
>
> Uncharacteristically unreviewed for a DSA patch :)

Yeah, I don't know what happened...