netdev - Re: [PATCH net-next 00/15] mlxsw: Preparations for nexthop objects support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201114165625.5190424f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 14 Nov 2020 16:56:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...dia.com,
        dsahern@...il.com, mlxsw@...dia.com,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 00/15] mlxsw: Preparations for nexthop objects
 support - part 1/2

On Fri, 13 Nov 2020 18:05:44 +0200 Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> This patch set contains small and non-functional changes aimed at making
> it easier to support nexthop objects in mlxsw. Follow up patches can be
> found here [1].
> 
> Patches #1-#4 add a type field to the nexthop group struct instead of
> the existing protocol field. This will be used later on to add a nexthop
> object type, which can contain both IPv4 and IPv6 nexthops.
> 
> Patches #5-#7 move the IPv4 FIB info pointer (i.e., 'struct fib_info')
> from the nexthop group struct to the route. The pointer will not be
> available when the nexthop group is a nexthop object, but it needs to be
> accessible to routes regardless.
> 
> Patch #8 is the biggest change, but it is an entirely cosmetic change
> and should therefore be easy to review. The motivation and the change
> itself are explained in detail in the commit message.
> 
> Patches #9-#12 perform small changes so that two functions that are
> currently split between IPv4 and IPv6 could be consolidated in patches
> #13 and #14. The functions will be reused for nexthop objects.
> 
> Patch #15 removes an outdated comment.

Pleasant read, applied, thanks!