netdev - Re: [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0200add-7970-dfea-b968-003d33bdfa72@infradead.org>
Date:   Mon, 16 Nov 2020 08:58:35 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netdev@...r.kernel.org, kernel test robot <lkp@...el.com>,
        "Jose M . Guisado Gomez" <guigom@...eup.net>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] netfilter: nf_reject: bridge: fix build errors
 due to code movement

On 11/16/20 1:26 AM, Pablo Neira Ayuso wrote:
> Hi,
> 
> Thanks for catching up this.
> 
> On Sun, Nov 15, 2020 at 07:42:03PM -0800, Randy Dunlap wrote:
>> Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
>> by selecting NF_REJECT_IPV4, which provides the missing symbols.
>>
>> ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
>> ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
>>
>> Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: kernel test robot <lkp@...el.com>
>> Cc: Jose M. Guisado Gomez <guigom@...eup.net>
>> Cc: Pablo Neira Ayuso <pablo@...filter.org>
>> Cc: Jozsef Kadlecsik <kadlec@...filter.org>
>> Cc: Florian Westphal <fw@...len.de>
>> Cc: netfilter-devel@...r.kernel.org
>> Cc: coreteam@...filter.org
>> Cc: Jakub Kicinski <kuba@...nel.org>
>> ---
>>  net/bridge/netfilter/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
>> +++ linux-next-20201113/net/bridge/netfilter/Kconfig
>> @@ -18,6 +18,7 @@ config NFT_BRIDGE_META
>>  config NFT_BRIDGE_REJECT
>>  	tristate "Netfilter nf_tables bridge reject support"
>>  	depends on NFT_REJECT
>> +	depends on NF_REJECT_IPV4
> 
> I can update the patch here before applying to add:
> 
>         depends on NF_REJECT_IPV6
> 
> as well. It seems both dependencies (IPv4 and IPv6) are missing.
> 
> Thanks.
> 
>>  	help
>>  	  Add support to reject packets.
>>  

Yes, that's good.

Thanks.

-- 
~Randy