netdev - Re: [PATCH v3 0/2] Fix usage counter leak by adding a general sync ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201116094041.7b6c4bc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 16 Nov 2020 09:40:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zhang Qilong <zhangqilong3@...wei.com>
Cc:     <rjw@...ysocki.net>, <fugang.duan@....com>, <davem@...emloft.net>,
        <linux-pm@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 0/2] Fix usage counter leak by adding a general sync
 ops

On Tue, 10 Nov 2020 17:29:31 +0800 Zhang Qilong wrote:
> In many case, we need to check return value of pm_runtime_get_sync,
> but it brings a trouble to the usage counter processing. Many callers
> forget to decrease the usage counter when it failed, which could
> resulted in reference leak. It has been discussed a lot[0][1]. So we
> add a function to deal with the usage counter for better coding and
> view. Then, we replace pm_runtime_resume_and_get with it in fec_main.c
> to avoid it.
> 
> [0]https://lkml.org/lkml/2020/6/14/88
> [1]https://patchwork.ozlabs.org/project/linux-tegra/list/?series=178139

Actually, I lied, this is a fix so applying to net, not net-next.

Thanks!