netdev - Re: [PATCH v3 1/1] page_frag: Recover from memory pressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Nov 2020 09:37:05 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>
Cc:     linux-mm <linux-mm@...ck.org>, netdev <netdev@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>,
        aruna.ramakrishna@...cle.com, bert.barbe@...cle.com,
        rama.nichanamatlu@...cle.com,
        "venkat x.venkatsubra" <venkat.x.venkatsubra@...cle.com>,
        manjunath.b.patil@...cle.com, joe.jin@...cle.com,
        srinivas.eeda@...cle.com, stable@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Miller <davem@...emloft.net>,
        Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH v3 1/1] page_frag: Recover from memory pressure

On Sun, Nov 15, 2020 at 9:16 PM Dongli Zhang <dongli.zhang@...cle.com> wrote:
>
> The ethernet driver may allocate skb (and skb->data) via napi_alloc_skb().
> This ends up to page_frag_alloc() to allocate skb->data from
> page_frag_cache->va.
>
> During the memory pressure, page_frag_cache->va may be allocated as
> pfmemalloc page. As a result, the skb->pfmemalloc is always true as
> skb->data is from page_frag_cache->va. The skb will be dropped if the
> sock (receiver) does not have SOCK_MEMALLOC. This is expected behaviour
> under memory pressure.
...
> References: https://lore.kernel.org/lkml/20201103193239.1807-1-dongli.zhang@oracle.com/
> References: https://lore.kernel.org/linux-mm/20201105042140.5253-1-willy@infradead.org/
> Suggested-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> Cc: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>
> Cc: Bert Barbe <bert.barbe@...cle.com>
> Cc: Rama Nichanamatlu <rama.nichanamatlu@...cle.com>
> Cc: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
> Cc: Manjunath Patil <manjunath.b.patil@...cle.com>
> Cc: Joe Jin <joe.jin@...cle.com>
> Cc: SRINIVAS <srinivas.eeda@...cle.com>
> Cc: stable@...r.kernel.org
> Fixes: 79930f5892e ("net: do not deplete pfmemalloc reserve")
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
> ---
> Changed since v1:
>   - change author from Matthew to Dongli
>   - Add references to all prior discussions
>   - Add more details to commit message
> Changed since v2:
>   - add unlikely (suggested by Eric Dumazet)
>
>  mm/page_alloc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 23f5066bd4a5..91129ce75ed4 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5103,6 +5103,11 @@ void *page_frag_alloc(struct page_frag_cache *nc,
>                 if (!page_ref_sub_and_test(page, nc->pagecnt_bias))
>                         goto refill;
>
> +               if (unlikely(nc->pfmemalloc)) {
> +                       free_the_page(page, compound_order(page));
> +                       goto refill;
> +               }
> +

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !