netdev - Re: [net 10/15] can: tcan4x5x: tcan4x5x_can_probe(): add missing error checking for devm_regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Nov 2020 08:01:09 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-can@...r.kernel.org>, <kernel@...gutronix.de>
Subject: Re: [net 10/15] can: tcan4x5x: tcan4x5x_can_probe(): add missing
 error checking for devm_regmap_init()

Marc

On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
> This patch adds the missing error checking when initializing the regmap
> interface fails.
>
> Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
> Cc: Dan Murphy <dmurphy@...com>
> Link: http://lore.kernel.org/r/20201019154233.1262589-7-mkl@pengutronix.de
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> ---
>   drivers/net/can/m_can/tcan4x5x.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c
> index eacd428e07e9..f058bd9104e9 100644
> --- a/drivers/net/can/m_can/tcan4x5x.c
> +++ b/drivers/net/can/m_can/tcan4x5x.c
> @@ -487,6 +487,10 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
>   
>   	priv->regmap = devm_regmap_init(&spi->dev, &tcan4x5x_bus,
>   					&spi->dev, &tcan4x5x_regmap);
> +	if (IS_ERR(priv->regmap)) {
> +		ret = PTR_ERR(priv->regmap);
> +		goto out_clk;
> +	}
>   
>   	ret = tcan4x5x_power_enable(priv->power, 1);
>   	if (ret)


Reviewed-by: Dan Murphy<dmurphy@...com>