netdev - Re: [PATCH] IPv6: RTM_GETROUTE: Add RTA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201116174655.57f5e35a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 16 Nov 2020 17:46:55 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Oliver Herms <oliver.peter.herms@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] IPv6: RTM_GETROUTE: Add RTA_ENCAP to result

On Sun, 15 Nov 2020 11:55:27 +0100 Oliver Herms wrote:
> This patch adds an IPv6 routes encapsulation attribute
> to the result of netlink RTM_GETROUTE requests
> (e.g. ip route get 2001:db8::).
> 
> Signed-off-by: Oliver Herms <oliver.peter.herms@...il.com>
> ---
>  net/ipv6/route.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 82cbb46a2a4f..4d45696a70eb 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -5489,6 +5489,11 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
>  	rtm->rtm_scope = RT_SCOPE_UNIVERSE;
>  	rtm->rtm_protocol = rt->fib6_protocol;
>  
> +	if (dst && dst->lwtstate &&
> +	    lwtunnel_fill_encap(skb, dst->lwtstate, RTA_ENCAP, RTA_ENCAP_TYPE) < 0) {
> +		goto nla_put_failure;
> +	}

curly brackets are not required around a single statement

Please fix and CC David Ahern, since he reviewed your corresponding
IPv4 patch.

Thanks!