netdev - Re: [PATCH net] atl1c: fix error return code in atl1c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201117124525.5c4b28b0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 17 Nov 2020 12:45:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marion & Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Zhang Changzhong <zhangchangzhong@...wei.com>, jcliburn@...il.com,
        chris.snook@...il.com, davem@...emloft.net, hkallweit1@...il.com,
        yanaijie@...wei.com, mst@...hat.com, leon@...nel.org,
        jesse.brandeburg@...el.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

On Tue, 17 Nov 2020 21:39:05 +0100 Marion & Christophe JAILLET wrote:
> Le 17/11/2020 à 03:55, Zhang Changzhong a écrit :
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API")  
> Hi, should it have any importance, the Fixes tag is wrong.
> 
> The issue was already there before 85eb5bc33717 which was just a 
> mechanical update.

Can you provide the correct one, then?

I can switch it when applying.