netdev - Re: [PATCH] vringh: fix vringh_iov_push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3aa02874-1c7f-d516-b80b-c79b33c0b1fd@redhat.com>
Date:   Tue, 17 Nov 2020 10:29:56 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Stefano Garzarella <sgarzare@...hat.com>, mst@...hat.com
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] vringh: fix vringh_iov_push_*() documentation


On 2020/11/17 上午12:16, Stefano Garzarella wrote:
> vringh_iov_push_*() functions don't have 'dst' parameter, but have
> the 'src' parameter.
>
> Replace 'dst' description with 'src' description.
>
> Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>


Acked-by: Jason Wang <jasowang@...hat.com>


> ---
>   drivers/vhost/vringh.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index 8bd8b403f087..b7403ba8e7f7 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -730,7 +730,7 @@ EXPORT_SYMBOL(vringh_iov_pull_user);
>   /**
>    * vringh_iov_push_user - copy bytes into vring_iov.
>    * @wiov: the wiov as passed to vringh_getdesc_user() (updated as we consume)
> - * @dst: the place to copy.
> + * @src: the place to copy from.
>    * @len: the maximum length to copy.
>    *
>    * Returns the bytes copied <= len or a negative errno.
> @@ -976,7 +976,7 @@ EXPORT_SYMBOL(vringh_iov_pull_kern);
>   /**
>    * vringh_iov_push_kern - copy bytes into vring_iov.
>    * @wiov: the wiov as passed to vringh_getdesc_kern() (updated as we consume)
> - * @dst: the place to copy.
> + * @src: the place to copy from.
>    * @len: the maximum length to copy.
>    *
>    * Returns the bytes copied <= len or a negative errno.
> @@ -1333,7 +1333,7 @@ EXPORT_SYMBOL(vringh_iov_pull_iotlb);
>    * vringh_iov_push_iotlb - copy bytes into vring_iov.
>    * @vrh: the vring.
>    * @wiov: the wiov as passed to vringh_getdesc_iotlb() (updated as we consume)
> - * @dst: the place to copy.
> + * @src: the place to copy from.
>    * @len: the maximum length to copy.
>    *
>    * Returns the bytes copied <= len or a negative errno.