netdev - Re: [PATCH net] enetc: Workaround for MDIO register access issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201117024450.GH1752213@lunn.ch>
Date:   Tue, 17 Nov 2020 03:44:50 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Claudiu Manoil <claudiu.manoil@....com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alex Marginean <alexandru.marginean@....com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net] enetc: Workaround for MDIO register access issue

> +static inline void enetc_lock_mdio(void)
> +{
> +	read_lock(&enetc_mdio_lock);
> +}
> +

> +static inline u32 _enetc_rd_mdio_reg_wa(void __iomem *reg)
> +{
> +	unsigned long flags;
> +	u32 val;
> +
> +	write_lock_irqsave(&enetc_mdio_lock, flags);
> +	val = ioread32(reg);
> +	write_unlock_irqrestore(&enetc_mdio_lock, flags);
> +
> +	return val;
> +}

Can you mix read_lock() with write_lock_irqsave()?  Normal locks you
should not mix, so i assume read/writes also cannot be mixed?

       Andrew