netdev - Re: [PATCH v3 net-next 1/3] net: dsa: tag_dsa: Allow forwarding of redirected IGMP traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201117024936.GI1752213@lunn.ch>
Date:   Tue, 17 Nov 2020 03:49:36 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Tobias Waldekranz <tobias@...dekranz.com>
Cc:     davem@...emloft.net, kuba@...nel.org, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 1/3] net: dsa: tag_dsa: Allow forwarding of
 redirected IGMP traffic

On Sun, Nov 15, 2020 at 12:45:56AM +0100, Tobias Waldekranz wrote:
> When receiving an IGMP/MLD frame with a TO_CPU tag, the switch has not
> performed any forwarding of it. This means that we should not set the
> offload_fwd_mark on the skb, in case a software bridge wants it
> forwarded.
> 
> This is a port of:
> 
> 1ed9ec9b08ad ("dsa: Allow forwarding of redirected IGMP traffic")
> 
> Which corrected the issue for chips using EDSA tags, but not for those
> using regular DSA tags.
> 
> Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew