netdev - Re: [PATCH net-next] net: phy: don't duplicate driver name in phy_attached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Nov 2020 03:53:54 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Russell King - ARM Linux <linux@...linux.org.uk>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: don't duplicate driver name in
 phy_attached_print

On Sun, Nov 15, 2020 at 04:03:10PM +0100, Heiner Kallweit wrote:
> Currently we print the driver name twice in phy_attached_print():
> - phy_dev_info() prints it as part of the device info
> - and we print it as part of the info string
> 
> This is a little bit ugly, it makes the info harder to read,
> especially if the driver name is a little bit longer.
> Therefore omit the driver name (if set) in the info string.
> 
> Example from r8169 that uses phylib:
> 
> old: Generic FE-GE Realtek PHY r8169-300:00: attached PHY driver \
>    [Generic FE-GE Realtek PHY] (mii_bus:phy_addr=r8169-300:00, irq=IGNORE)
> new: Generic FE-GE Realtek PHY r8169-300:00: attached PHY driver \
>    (mii_bus:phy_addr=r8169-300:00, irq=IGNORE)
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew