netdev - Re: [PATCH net-next v4 5/6] selftests: refactor get_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201118090320.wdth32bkz3ro6mbc@yoda.fritz.box>
Date:   Wed, 18 Nov 2020 10:03:20 +0100
From:   Antonio Cardace <acardace@...hat.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v4 5/6] selftests: refactor get_netdev_name
 function

On Tue, Nov 17, 2020 at 06:35:20PM +0100, Michal Kubecek wrote:
> On Tue, Nov 17, 2020 at 04:20:14PM +0100, Antonio Cardace wrote:
> > As pointed out by Michal Kubecek, getting the name
> > with the previous approach was racy, it's better
> > and easier to get the name of the device with this
> > patch's approach.
> > 
> > Essentialy the function doesn't need to exist
> > anymore as it's a simple 'ls' command.
> > 
> > Signed-off-by: Antonio Cardace <acardace@...hat.com>
> > ---
> >  .../drivers/net/netdevsim/ethtool-common.sh   | 20 ++-----------------
> >  1 file changed, 2 insertions(+), 18 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
> > index fa44cf6e732c..3c287ac78117 100644
> > --- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
> > +++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
> > @@ -20,23 +20,6 @@ function cleanup {
> > 
> >  trap cleanup EXIT
> > 
> > -function get_netdev_name {
> > -    local -n old=$1
> > -
> > -    new=$(ls /sys/class/net)
> > -
> > -    for netdev in $new; do
> > -	for check in $old; do
> > -            [ $netdev == $check ] && break
> > -	done
> > -
> > -	if [ $netdev != $check ]; then
> > -	    echo $netdev
> > -	    break
> > -	fi
> > -    done
> > -}
> > -
> >  function check {
> >      local code=$1
> >      local str=$2
> > @@ -65,5 +48,6 @@ function make_netdev {
> >      fi
> > 
> >      echo $NSIM_ID > /sys/bus/netdevsim/new_device
> > -    echo `get_netdev_name old_netdevs`
> > +    # get new device name
> > +    echo $(ls /sys/bus/netdevsim/devices/netdevsim${NSIM_ID}/net/)
> 
> Is there a reason for combining command substitution with echo? Couldn't
> we use one of
> 
>   ls /sys/bus/netdevsim/devices/netdevsim${NSIM_ID}/net/
>   echo /sys/bus/netdevsim/devices/netdevsim${NSIM_ID}/net/*
> 
> instead?
> 
> Michal
> 
Ouch, no that's just a mistake. I'll fix it.

Do I have to resend the whole serie as a new version or is there a
quicker way to just resend a single patch?

Thanks,
Antonio