netdev - Re: [PATCH net] vhost_vdpa: Return -EFUALT if copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ac146a2-a3db-abc7-73a0-98f71119de3d@redhat.com>
Date:   Wed, 18 Nov 2020 17:39:51 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net] vhost_vdpa: Return -EFUALT if copy_from_user() fails


On 2020/11/18 下午4:59, Michael S. Tsirkin wrote:
> On Wed, Nov 18, 2020 at 02:08:17PM +0800, Jason Wang wrote:
>> On 2020/10/26 上午10:59, Jason Wang wrote:
>>> On 2020/10/23 下午11:34, Michael S. Tsirkin wrote:
>>>> On Fri, Oct 23, 2020 at 03:08:53PM +0300, Dan Carpenter wrote:
>>>>> The copy_to/from_user() functions return the number of bytes which we
>>>>> weren't able to copy but the ioctl should return -EFAULT if they fail.
>>>>>
>>>>> Fixes: a127c5bbb6a8 ("vhost-vdpa: fix backend feature ioctls")
>>>>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>>>> Acked-by: Michael S. Tsirkin <mst@...hat.com>
>>>> Needed for stable I guess.
>>>
>>> Agree.
>>>
>>> Acked-by: Jason Wang <jasowang@...hat.com>
>>
>> Hi Michael.
>>
>> I don't see this in your tree, please consider to merge.
>>
>> Thanks
>>
> I do see it there:
>
> commit 7922460e33c81f41e0d2421417228b32e6fdbe94
> Author: Dan Carpenter <dan.carpenter@...cle.com>
> Date:   Fri Oct 23 15:08:53 2020 +0300
>
>      vhost_vdpa: Return -EFAULT if copy_from_user() fails
>      
> the reason you can't find it is probably because I fixed up
> a typo in the subject.


I see that.

Thanks


>
>