netdev - Re: [PATCH] bus: mhi: Remove auto-start option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Nov 2020 19:55:19 +0800
From:   Carl Huang <cjhuang@...eaurora.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        Loic Poulain <loic.poulain@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-wireless@...r.kernel.org,
        bbhatt@...eaurora.org, netdev@...r.kernel.org,
        hemantk@...eaurora.org, ath11k@...ts.infradead.org
Subject: Re: [PATCH] bus: mhi: Remove auto-start option

On 2020-11-18 17:31, Manivannan Sadhasivam wrote:
> On Wed, Nov 18, 2020 at 07:43:48AM +0200, Kalle Valo wrote:
>> Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> writes:
>> 
>> > From: Loic Poulain <loic.poulain@...aro.org>
>> >
>> > There is really no point having an auto-start for channels.
>> > This is confusing for the device drivers, some have to enable the
>> > channels, others don't have... and waste resources (e.g. pre allocated
>> > buffers) that may never be used.
>> >
>> > This is really up to the MHI device(channel) driver to manage the state
>> > of its channels.
>> >
>> > While at it, let's also remove the auto-start option from ath11k mhi
>> > controller.
>> >
>> > Signed-off-by: Loic Poulain <loic.poulain@...aro.org>
>> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>> > [mani: clubbed ath11k change]
>> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>> 
>> Thanks and feel free to take this to the immutable branch:
>> 
>> Acked-by: Kalle Valo <kvalo@...eaurora.org>
> 
> Patch applied to mhi-ath11k-immutable branch and merged into mhi-next.
> 
> Thanks,
> Mani
> 
Does net/qrtr/mhi.c need changes? I guess now net/qrtr/mhi.c needs to 
call
mhi_prepare_for_transfer() before transfer.

>> 
>> --
>> https://patchwork.kernel.org/project/linux-wireless/list/
>> 
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches