netdev - Re: [RFC, net-next] net: qos: introduce a redundancy flow action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc5d88d6-ca5e-59f5-cf3d-edfecce46dd4@mojatatu.com>
Date:   Wed, 18 Nov 2020 11:11:25 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Joergen Andreasen <joergen.andreasen@...rochip.com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, Arvid.Brodin@...n.com,
        m-karicheri2@...com, vinicius.gomes@...el.com,
        michael.chan@...adcom.com, vishal@...lsio.com, saeedm@...lanox.com,
        jiri@...lanox.com, idosch@...lanox.com,
        alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com,
        ivan.khoronzhuk@...aro.org, andre.guedes@...ux.intel.com,
        allan.nielsen@...rochip.com, po.liu@....com, mingkai.hu@....com,
        claudiu.manoil@....com, vladimir.oltean@....com,
        leoyang.li@....com, Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [RFC, net-next] net: qos: introduce a redundancy flow action

On 2020-11-17 2:00 p.m., Joergen Andreasen wrote:
> The 11/17/2020 14:30, Xiaoliang Yang wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> This patch introduce a redundancy flow action to implement frame
>> replication and elimination for reliability, which is defined in
>> IEEE P802.1CB.
>>
>> There are two modes for redundancy action: generator and recover mode.
>> Generator mode add redundancy tag and replicate the frame to different
>> egress ports. Recover mode drop the repeat frames and remove redundancy
>> tag from the frame.
>>
>> Below is the setting example in user space:
>>          > tc qdisc add dev swp0 clsact
>>          > tc filter add dev swp0 ingress protocol 802.1Q flower \
>>                  skip_hw dst_mac 00:01:02:03:04:05 vlan_id 1 \
>>                  action redundancy generator split dev swp1 dev swp2
>>
>>          > tc filter add dev swp0 ingress protocol 802.1Q flower
>>                  skip_hw dst_mac 00:01:02:03:04:06 vlan_id 1 \
>>                  action redundancy recover
>>

Please CC _all_ maintainers for best feedback (+Cc Cong)
and it is unnecessary to cc lists like linux-kernel (removed).

We already have mirroring + ability to add/pop tags.
Would the following not work?

Example, generator mode:
tc filter add dev swp0 ingress protocol 802.1Q flower \
action vlan push id 789 protocol 802.1q \
action mirred egress mirror dev swp1 \
action mirred egress mirror dev swp2

recovery mode:
tc filter add dev swp0 ingress protocol 802.1Q flower \
skip_hw dst_mac 00:01:02:03:04:06 vlan_id 1 \
actopm vlan pop


cheers,
jamal