netdev - Re: [PATCH net] net/sched: act_mpls: ensure LSE is pullable before reading it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201118180046.GA449907@localhost.localdomain>
Date:   Wed, 18 Nov 2020 15:00:46 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>, gnault@...hat.com
Subject: Re: [PATCH net] net/sched: act_mpls: ensure LSE is pullable before
 reading it

On Wed, Nov 18, 2020 at 06:07:22PM +0100, Davide Caratti wrote:
> On Wed, 2020-11-18 at 13:47 -0300, Marcelo Ricardo Leitner wrote:
> > On Wed, Nov 18, 2020 at 05:36:52PM +0100, Davide Caratti wrote:
> > 
> > Hi,
> > 
> > >  	case TCA_MPLS_ACT_MODIFY:
> > > +		if (!pskb_may_pull(skb,
> > > +				   skb_network_offset(skb) + sizeof(new_lse)))
> > > +			goto drop;
> > >  		new_lse = tcf_mpls_get_lse(mpls_hdr(skb), p, false);
> > >  		if (skb_mpls_update_lse(skb, new_lse))
> > >  			goto drop;
> > 
> > Seems TCA_MPLS_ACT_DEC_TTL is also affected. skb_mpls_dec_ttl() will
> > also call mpls_hdr(skb) without this check.
> > 
> >   Marcelo
> > 
> ... yes, correct; and at a first glance, also set_mpls() in
> openvswitch/action.c has the same (theoretical) issue. I will follow-up
> with other 2 patches, ok?

Yep! Thanks.

Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>