netdev - Re: [net-next v2 PATCH] devlink: move request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0371781e-f411-e78e-be6d-971e8989d6ba@intel.com>
Date:   Wed, 18 Nov 2020 10:52:23 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Shannon Nelson <snelson@...sando.io>, netdev@...r.kernel.org
Cc:     Jiri Pirko <jiri@...dia.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Boris Pismenny <borisp@...dia.com>,
        Bin Luo <luobin9@...wei.com>, Jakub Kicinksi <kuba@...nel.org>
Subject: Re: [net-next v2 PATCH] devlink: move request_firmware out of driver



On 11/13/2020 3:48 PM, Shannon Nelson wrote:
> On 11/13/20 2:45 PM, Jacob Keller wrote:
>> -int ionic_firmware_update(struct ionic_lif *lif, const char *fw_name,
>> +int ionic_firmware_update(struct ionic_lif *lif, const struct firmware *fw,
>>   			  struct netlink_ext_ack *extack)
>>   {
>>   	struct ionic_dev *idev = &lif->ionic->idev;
>> @@ -99,24 +99,15 @@ int ionic_firmware_update(struct ionic_lif *lif, const char *fw_name,
>>   	struct ionic *ionic = lif->ionic;
>>   	union ionic_dev_cmd_comp comp;
>>   	u32 buf_sz, copy_sz, offset;
>> -	const struct firmware *fw;
>>   	struct devlink *dl;
>>   	int next_interval;
>>   	int err = 0;
>>   	u8 fw_slot;
>>   
>> -	netdev_info(netdev, "Installing firmware %s\n", fw_name);
>> -
> 
> I prefer keeping the chatty little bits like this for debug purposes, 
> but if you're going to remove it, then you should remove the matching 
> netdev_info "Firmware update completed" message a few lines before the 
> release_firmware().
> 
> Aside from that, for the ionic bits:
> Acked-by: Shannon Nelson <snelson@...sando.io>
> 
> Thanks,
> sln
> 

So the only reason I removed this is because the function no longer has
access to the fw_name string. I'll change it to just remove the %s
format string.