netdev - Re: [PATCH net-next v3 2/5] net: add sysfs attribute to control napi threaded mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8578cfd8-dcaf-5a86-7803-922ee27d9e90@infradead.org>
Date:   Wed, 18 Nov 2020 12:36:03 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Wei Wang <weiwan@...gle.com>, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Eric Dumazet <edumazet@...gle.com>, Felix Fietkau <nbd@....name>,
        Paolo Abeni <pabeni@...hat.com>,
        Hannes Frederic Sowa <hannes@...essinduktion.org>,
        Hillf Danton <hdanton@...a.com>
Subject: Re: [PATCH net-next v3 2/5] net: add sysfs attribute to control napi
 threaded mode

On 11/18/20 11:10 AM, Wei Wang wrote:
> From: Paolo Abeni <pabeni@...hat.com> 
> 
> this patch adds a new sysfs attribute to the network
> device class. Said attribute is a bitmask that allows controlling
> the threaded mode for all the napi instances of the given
> network device.
> 
> The threaded mode can be switched only if related network device
> is down.
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Hi,

Could someone describe the bitmask (is it a bit per instance of the
network device?).
And how to use the sysfs interface, please?

> ---
>  net/core/net-sysfs.c | 103 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 103 insertions(+)
> 
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index 94fff0700bdd..df8dd25e5e4b 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c


thanks.
-- 
~Randy