netdev - Re: [PATCH net-next,v4 2/9] netfilter: flowtable: add xmit path types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201118233615.GD15137@breakpoint.cc>
Date:   Thu, 19 Nov 2020 00:36:15 +0100
From:   Florian Westphal <fw@...len.de>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netfilter-devel@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org, kuba@...nel.org, razor@...ckwall.org,
        tobias@...dekranz.com, jeremy@...zel.net
Subject: Re: [PATCH net-next,v4 2/9] netfilter: flowtable: add xmit path types

Pablo Neira Ayuso <pablo@...filter.org> wrote:
> -	if (unlikely(dst_xfrm(&rt->dst))) {
> +	rt = (struct rtable *)tuplehash->tuple.dst_cache;
> +
> +	if (unlikely(tuplehash->tuple.xmit_type == FLOW_OFFLOAD_XMIT_XFRM)) {
>  		memset(skb->cb, 0, sizeof(struct inet_skb_parm));
>  		IPCB(skb)->iif = skb->dev->ifindex;
>  		IPCB(skb)->flags = IPSKB_FORWARDED;
>  		return nf_flow_xmit_xfrm(skb, state, &rt->dst);
>  	}
[..]

> +
> +	if (unlikely(tuplehash->tuple.xmit_type == FLOW_OFFLOAD_XMIT_NEIGH))

This needs to be XMIT_XFRM too.