netdev - Re: [net v2] net/tls: missing received data after fast remote close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7300af8-7776-5f7a-9241-499865b24e47@novek.ru>
Date:   Thu, 19 Nov 2020 15:58:02 +0000
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Jakub Kicinski <kuba@...nel.org>,
        Boris Pismenny <borisp@...dia.com>,
        Aviad Yehezkel <aviadye@...dia.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [net v2] net/tls: missing received data after fast remote close

On 19.11.2020 01:13, Vadim Fedorenko wrote:
> In case when tcp socket received FIN after some data and the
> parser haven't started before reading data caller will receive
> an empty buffer. This behavior differs from plain TCP socket and
> leads to special treating in user-space.
> The flow that triggers the race is simple. Server sends small
> amount of data right after the connection is configured to use TLS
> and closes the connection. In this case receiver sees TLS Handshake
> data, configures TLS socket right after Change Cipher Spec record.
> While the configuration is in process, TCP socket receives small
> Application Data record, Encrypted Alert record and FIN packet. So
> the TCP socket changes sk_shutdown to RCV_SHUTDOWN and sk_flag with
> SK_DONE bit set. The received data is not parsed upon arrival and is
> never sent to user-space.
>
> Patch unpauses parser directly if we have unparsed data in tcp
> receive queue.
>
>
Please ignore this one, it hase typo mistake.