netdev - Re: [PATCH net-next] r8169: remove not needed check in rtl8169_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201118172733.5beac078@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Wed, 18 Nov 2020 17:27:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: remove not needed check in
 rtl8169_start_xmit

On Tue, 17 Nov 2020 21:34:09 +0100 Heiner Kallweit wrote:
> In rtl_tx() the released descriptors are zero'ed by
> rtl8169_unmap_tx_skb(). And in the beginning of rtl8169_start_xmit()
> we check that enough descriptors are free, therefore there's no way
> the DescOwn bit can be set here.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks!