netdev - Re: [PATCH 03/11] net: dsa: microchip: ksz8795: move variable assignments from detect to init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201119001401.GG1804098@lunn.ch>
Date:   Thu, 19 Nov 2020 01:14:01 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com, davem@...emloft.net,
        kernel@...gutronix.de, matthias.schiffer@...tq-group.com,
        woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH 03/11] net: dsa: microchip: ksz8795: move variable
 assignments from detect to init

On Wed, Nov 18, 2020 at 11:03:49PM +0100, Michael Grzeschik wrote:
> This patch moves all variable assignments to the init function. It
> leaves the detect function for its single purpose to detect which chip
> version is found.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew