netdev - Re: [PATCH 05/11] net: dsa: microchip: ksz8795: use mib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Nov 2020 15:01:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>,
        netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, andrew@...n.ch, f.fainelli@...il.com,
        davem@...emloft.net, kernel@...gutronix.de,
        matthias.schiffer@...tq-group.com, woojung.huh@...rochip.com,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH 05/11] net: dsa: microchip: ksz8795: use mib_cnt where
 possible

Hi Michael,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on net-next/master ipvs/master linus/master v5.10-rc4 next-20201118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Michael-Grzeschik/net-dsa-microchip-make-ksz8795-driver-more-dynamic/20201119-060705
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git a3dcb3e7e70c72a68a79b30fc3a3adad5612731c
config: h8300-randconfig-r031-20201119 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9debc1a2179402cc4391e253c57fafa0ef357e05
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Grzeschik/net-dsa-microchip-make-ksz8795-driver-more-dynamic/20201119-060705
        git checkout 9debc1a2179402cc4391e253c57fafa0ef357e05
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/dsa/microchip/ksz8795.c: In function 'ksz8795_get_strings':
>> drivers/net/dsa/microchip/ksz8795.c:659:18: error: 'dev' undeclared (first use in this function); did you mean 'cdev'?
     659 |  for (i = 0; i < dev->mib_cnt; i++) {
         |                  ^~~
         |                  cdev
   drivers/net/dsa/microchip/ksz8795.c:659:18: note: each undeclared identifier is reported only once for each function it appears in

vim +659 drivers/net/dsa/microchip/ksz8795.c

   653	
   654	static void ksz8795_get_strings(struct dsa_switch *ds, int port,
   655					u32 stringset, uint8_t *buf)
   656	{
   657		int i;
   658	
 > 659		for (i = 0; i < dev->mib_cnt; i++) {
   660			memcpy(buf + i * ETH_GSTRING_LEN, mib_names[i].string,
   661			       ETH_GSTRING_LEN);
   662		}
   663	}
   664	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (28874 bytes)