netdev - Re: [PATCH] cxbgb4: Fix build failure when CHELSIO_TLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201120073502.4beeb482@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Fri, 20 Nov 2020 07:35:02 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tom Seewald <tseewald@...il.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] cxbgb4: Fix build failure when CHELSIO_TLS_DEVICE=n

On Fri, 20 Nov 2020 00:54:00 -0600 Tom Seewald wrote:
> > Seems to me that CHELSIO_T4 should depend on (TLS || TLS=n), the
> > CONFIG_CHELSIO_TLS_DEVICE has the dependency but AFAICT nothing prevents
> > CONFIG_CHELSIO_TLS_DEVICE=m and CHELSIO_T4=y and cxgb4_main.c is under
> > the latter.  
> 
> You are right, adding (TLS || TLS=n) for CHELSIO_T4 resolves the build
> error I am encountering.

Great, please submit a patch.