netdev - Re: [PATCH bpf-next] bpf: simplify task_file_seq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c8b7242-7236-b3ce-a0f2-c2fe651ab079@fb.com>
Date:   Fri, 20 Nov 2020 08:57:55 -0800
From:   Yonghong Song <yhs@...com>
To:     Song Liu <songliubraving@...com>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>
CC:     <kernel-team@...com>, <ast@...nel.org>, <daniel@...earbox.net>,
        <andrii@...nel.org>, <kpsingh@...omium.org>,
        <john.fastabend@...il.com>
Subject: Re: [PATCH bpf-next] bpf: simplify task_file_seq_get_next()



On 11/19/20 4:28 PM, Song Liu wrote:
> Simplify task_file_seq_get_next() by removing two in/out arguments: task
> and fstruct. Use info->task and info->files instead.
> 
> Cc: Yonghong Song <yhs@...com>
> Signed-off-by: Song Liu <songliubraving@...com>

Thanks for the refactor. The new code is shorter and cleaner.

Acked-by: Yonghong Song <yhs@...com>

> ---
>   kernel/bpf/task_iter.c | 53 ++++++++++++++----------------------------
>   1 file changed, 17 insertions(+), 36 deletions(-)