netdev - Re: [PATCH v10 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Nov 2020 01:59:51 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Pavana Sharma <pavana.sharma@...i.com>
Cc:     lkp@...el.com, ashkan.boldaji@...i.com,
        clang-built-linux@...glegroups.com, davem@...emloft.net,
        f.fainelli@...il.com, gregkh@...uxfoundation.org,
        kbuild-all@...ts.01.org, kuba@...nel.org,
        linux-kernel@...r.kernel.org, marek.behun@....cz,
        netdev@...r.kernel.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org, vivien.didelot@...il.com
Subject: Re: [PATCH v10 3/4] net: dsa: mv88e6xxx: Change serdes lane
 parameter from  u8 type to int

> @@ -459,7 +459,7 @@ static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int port,
>  		chip->ports[port].cmode = cmode;
>  
>  		lane = mv88e6xxx_serdes_get_lane(chip, port);
> -		if (!lane)
> +		if (lane < 0)
>  			return -ENODEV;

return lane

since lane is an errno.

Other than that:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew