netdev - Re: [PATCH net-next v2 2/2] lib8390: Cleanup variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201120120235.1925e713@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 20 Nov 2020 12:02:35 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Armin Wolf <W_Armin@....de>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, f.fainelli@...il.com,
        joe@...ches.com
Subject: Re: [PATCH net-next v2 2/2] lib8390: Cleanup variables

On Wed, 18 Nov 2020 17:51:07 +0100 Armin Wolf wrote:
>  	unsigned long e8390_base = dev->base_addr;
>  	struct ei_device *ei_local = netdev_priv(dev);
> -	int send_length, output_page;
> +	int output_page;
>  	unsigned long flags;

The last two lines should be swapped to follow the reverse xmas tree
ordering of variables.

More importantly this driver is marked as:

S:	Orphan / Obsolete

in MAINTAINERS. Are you actually using hardware which needs this code,
or are those changes purely based on code inspection?

You should either change the state of the driver in MAINTAINERS, or find
another driver / part of the kernel to refactor.