netdev - Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201120144824.2fc3eda0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 20 Nov 2020 14:48:24 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        mkubecek@...e.cz, linux-rdma@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h

On Fri, 20 Nov 2020 23:28:28 +0100 Johannes Berg wrote:
> On Fri, 2020-11-20 at 14:13 -0800, Jakub Kicinski wrote:
> > linux/netdevice.h is included in very many places, touching any
> > of its dependecies causes large incremental builds.
> > 
> > Drop the linux/ethtool.h include, linux/netdevice.h just needs
> > a forward declaration of struct ethtool_ops.
> > 
> > Fix all the places which made use of this implicit include.  
> 
> >  include/net/cfg80211.h                                   | 1 +  
> 
> Sounds good to me, thanks. Will still cause all wireless drivers to
> rebuild this way though. Maybe I'll see later if something can be done
> about that.
> 
> Acked-by: Johannes Berg <johannes@...solutions.net>

Same for RDMA, sadly. Both need the firmware version string length.

One simple way to narrow things down would be to include only the uapi
version. Or we can duplicate the define, AFAIR duplicate defines are ok
as long as they are identical.

But not sure it's worth it, I'm happy enough with the 2x reduction in
objects getting rebuilt :)