netdev - Re: [PATCH net-next v2] net: openvswitch: Be liberal in tcp conntrack.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201119205749.0c3eaf8b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 19 Nov 2020 20:57:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     nusiddiq@...hat.com
Cc:     dev@...nvswitch.org, netdev@...r.kernel.org,
        Pravin B Shelar <pshelar@....org>,
        Florian Westphal <fw@...len.de>,
        netfilter-devel@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH net-next v2] net: openvswitch: Be liberal in tcp
 conntrack.

On Mon, 16 Nov 2020 18:31:26 +0530 nusiddiq@...hat.com wrote:
> From: Numan Siddique <nusiddiq@...hat.com>
> 
> There is no easy way to distinguish if a conntracked tcp packet is
> marked invalid because of tcp_in_window() check error or because
> it doesn't belong to an existing connection. With this patch,
> openvswitch sets liberal tcp flag for the established sessions so
> that out of window packets are not marked invalid.
> 
> A helper function - nf_ct_set_tcp_be_liberal(nf_conn) is added which
> sets this flag for both the directions of the nf_conn.
> 
> Suggested-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Numan Siddique <nusiddiq@...hat.com>

Florian, LGTY?