netdev - Re: [net-next v4 0/2] devlink: move common flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201119214335.21a244a7@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 19 Nov 2020 21:43:35 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...dia.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Shannon Nelson <snelson@...sando.io>,
        Saeed Mahameed <saeedm@...dia.com>,
        Boris Pismenny <borisp@...dia.com>,
        Bin Luo <luobin9@...wei.com>
Subject: Re: [net-next v4 0/2] devlink: move common flash_update calls to
 core

On Wed, 18 Nov 2020 11:06:34 -0800 Jacob Keller wrote:
> This series moves a couple common pieces done by all drivers of the
> ->flash_update interface into devlink.c flash update handler. Specifically,  
> the core code will now request_firmware and
> devlink_flash_update_(begin|end)_notify.
> 
> This cleanup is intended to simplify driver implementations so that they
> have less work to do and are less capable of doing the "wrong" thing.
> 
> For request_firmware, this simplification is done as it is not expected that
> drivers would do anything else. It also standardizes all drivers so that
> they use the same interface (request_firmware, as opposed to
> request_firmware_direct), and allows reporting the netlink extended ack with
> the file name attribute.
> 
> For status notification, this change prevents drivers from sending a status
> message without properly sending the status end notification. The current
> userspace implementation of devlink relies on this end notification to
> properly close the flash update channel. Without this, the flash update
> process may hang indefinitely. By moving the begin and end calls into the
> core code, it is no longer possible for a driver author to get this wrong.
> 
> Changes since v3
> * picked up acked-by and reviewed-by comments
> * fixed the ionic driver to leave the print statement in place
> 
> For the original patch that moved request_firmware, see [1]. For the v2 see
> [2]. For further discussion of the issues with devlink flash status see [3].
> For v3 see [4].

Applied, thanks!