netdev - Re: [PATCH] tun: honor IOCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201121151952.6a0d9c46@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 21 Nov 2020 15:19:52 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH] tun: honor IOCB_NOWAIT flag

On Fri, 20 Nov 2020 07:59:54 -0700 Jens Axboe wrote:
> tun only checks the file O_NONBLOCK flag, but it should also be checking
> the iocb IOCB_NOWAIT flag. Any fops using ->read/write_iter() should check
> both, otherwise it breaks users that correctly expect O_NONBLOCK semantics
> if IOCB_NOWAIT is set.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Jens Axboe <axboe@...nel.dk>

Applied, thanks!