netdev - Re: [EXT] Re: [RFC, net-next] net: qos: introduce a redundancy flow action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6b689ba-bf11-fec8-6ede-c8f6675085e1@mojatatu.com>
Date:   Sat, 21 Nov 2020 07:43:17 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Arvid.Brodin@...n.com" <Arvid.Brodin@...n.com>,
        "m-karicheri2@...com" <m-karicheri2@...com>,
        "vinicius.gomes@...el.com" <vinicius.gomes@...el.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        "vishal@...lsio.com" <vishal@...lsio.com>,
        "saeedm@...lanox.com" <saeedm@...lanox.com>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "ivan.khoronzhuk@...aro.org" <ivan.khoronzhuk@...aro.org>,
        "andre.guedes@...ux.intel.com" <andre.guedes@...ux.intel.com>,
        "allan.nielsen@...rochip.com" <allan.nielsen@...rochip.com>,
        Po Liu <po.liu@....com>, Mingkai Hu <mingkai.hu@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Leo Li <leoyang.li@....com>,
        Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [EXT] Re: [RFC, net-next] net: qos: introduce a redundancy flow
 action

Hi,

On 2020-11-20 2:32 a.m., Xiaoliang Yang wrote:
> Hi Jamal,
> 
> On 2020-11-19 0:11, Jamal Hadi Salim wrote:
>> The 11/17/2020 14:30, Xiaoliang Yang wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you

[..]

>> We already have mirroring + ability to add/pop tags.
>> Would the following not work?
>>
>> Example, generator mode:
>> tc filter add dev swp0 ingress protocol 802.1Q flower \ 
action vlan push id 789 protocol 802.1q \ action mirred egress mirror 
dev swp1 \ action mirred egress mirror dev swp2
>>
>> recovery mode:
>> tc filter add dev swp0 ingress protocol 802.1Q flower \ skip_hw dst_mac 00:01:02:03:04:06 vlan_id 1 \ actopm vlan pop
>>
> 
> Action mirred only copy the packets and forward to different egress ports. 

Also to ingress of ports (and can redirect as well, etc)

>802.1CB need to add a redundancy tag before forward. Recovery mode need pop the
redundancy tag
and check sequence in R-TAG, drop the repeat frames. So I added a new 
action to do this.
> 

Ok, when you said "tags" I thought you meant 802.1q tags. But seems like
different ethernet tags?
The preferred approach is to write an action to pop/push these R-TAGs.

generator mode:
tc filter add dev swp0 ingress protocol 802.1Q flower \
action rtag push \
action mirred egress mirror dev swp1 \
action mirred egress mirror dev swp2

recovery mode:
tc filter add dev swp0 ingress protocol 802.1Q flower \
action rtag pop
...
.....

We have a few examplery actions which provide tags at L2
(IFE, MPLS, VLAN, etc).

cheers,
jamal