netdev - Re: [PATCH] net: mlx5e: fix fs_tcp.c build when IPV6 is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9f9b9f1eb31f48f1cb19b66986ecba03f7aabd2.camel@kernel.org>
Date:   Mon, 23 Nov 2020 13:19:10 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Tariq Toukan <ttoukan.linux@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>, netdev@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>,
        Boris Pismenny <borisp@...dia.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] net: mlx5e: fix fs_tcp.c build when IPV6 is not enabled

On Mon, 2020-11-23 at 12:08 +0200, Tariq Toukan wrote:
> 
> On 11/22/2020 11:12 PM, Randy Dunlap wrote:
> > Fix build when CONFIG_IPV6 is not enabled by making a function
> > be built conditionally.
> > 
> > Fixes these build errors and warnings:
> > 
> > ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c: In
> > function 'accel_fs_tcp_set_ipv6_flow':
> > ../include/net/sock.h:380:34: error: 'struct sock_common' has no
> > member named 'skc_v6_daddr'; did you mean 'skc_daddr'?
> >    380 | #define sk_v6_daddr  __sk_common.skc_v6_daddr
> >        |                                  ^~~~~~~~~~~~
> > ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c:55:14:
> > note: in expansion of macro 'sk_v6_daddr'
> >     55 |         &sk->sk_v6_daddr, 16);
> >        |              ^~~~~~~~~~~
> > At top level:
> > ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c:47:13:
> > warning: 'accel_fs_tcp_set_ipv6_flow' defined but not used [-
> > Wunused-function]
> >     47 | static void accel_fs_tcp_set_ipv6_flow(struct
> > mlx5_flow_spec *spec, struct sock *sk)
> > 
> > Fixes: 5229a96e59ec ("net/mlx5e: Accel, Expose flow steering API
> > for rules add/del")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Cc: Saeed Mahameed <saeedm@...dia.com>
> > Cc: Boris Pismenny <borisp@...dia.com>
> > Cc: Tariq Toukan <tariqt@...lanox.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > ---
> 
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> 
> 
Applied to net-mlx5,
Thanks!