[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20201123144126.00003133@intel.com>
Date: Mon, 23 Nov 2020 14:41:26 -0800
From: Jesse Brandeburg <jesse.brandeburg@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
mkubecek@...e.cz, linux-rdma@...r.kernel.org,
linux-wireless@...r.kernel.org,
Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH net-next v2] net: don't include ethtool.h from
netdevice.h
Jakub Kicinski wrote:
> linux/netdevice.h is included in very many places, touching any
> of its dependecies causes large incremental builds.
>
> Drop the linux/ethtool.h include, linux/netdevice.h just needs
> a forward declaration of struct ethtool_ops.
>
> Fix all the places which made use of this implicit include.
>
> Acked-by: Johannes Berg <johannes@...solutions.net>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
Powered by blists - more mailing lists