netdev - Re: [PATCH] lsm,selinux: pass flowi_common instead of flowi to the LSM hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhStm9LXL1cG3ATS0Z=EkJSbZ7GPLWfRwb=ZiQMJc2e8qQ@mail.gmail.com>
Date:   Mon, 23 Nov 2020 18:47:17 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     James Morris <jmorris@...ei.org>
Cc:     linux-security-module@...r.kernel.org, netdev@...r.kernel.org,
        selinux@...r.kernel.org, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] lsm,selinux: pass flowi_common instead of flowi to the
 LSM hooks

On Thu, Nov 19, 2020 at 10:02 PM James Morris <jmorris@...ei.org> wrote:
> On Thu, 19 Nov 2020, Paul Moore wrote:
> > As pointed out by Herbert in a recent related patch, the LSM hooks do
> > not have the necessary address family information to use the flowi
> > struct safely.  As none of the LSMs currently use any of the protocol
> > specific flowi information, replace the flowi pointers with pointers
> > to the address family independent flowi_common struct.
> >
> > Reported-by: Herbert Xu <herbert@...dor.apana.org.au>
> > Signed-off-by: Paul Moore <paul@...l-moore.com>
>
> Acked-by: James Morris <jamorris@...ux.microsoft.com>

Thanks.  Seeing no further comments or objections, and given the
discussion in the previous draft of the patch, I've gone again and
merged this into selinux/next.

-- 
paul moore
www.paul-moore.com