netdev - Re: [PATCH net] Bluetooth: Fix potential null pointer dereference in create_le_conn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2E78F25D-78D0-410A-8EAD-76BA4466975B@holtmann.org>
Date:   Mon, 23 Nov 2020 12:58:10 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Wang Hai <wanghai38@...wei.com>
Cc:     "David S. Miller" <davem@...emloft.net>, kuba@...nel.org,
        Johan Hedberg <johan.hedberg@...il.com>, jpawlowski@...gle.com,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] Bluetooth: Fix potential null pointer dereference in
 create_le_conn_complete

Hi Wang,

> The pointer 'conn' may be null. Before being used by
> hci_connect_le_scan_cleanup(), The pointer 'conn' must be
> checked whether it is null.
> 
> Fixes: 28a667c9c279 ("Bluetooth: advertisement handling in new connect procedure")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
> net/bluetooth/hci_conn.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

please send a version that applies cleanly against bluetooth-next tree.

Regards

Marcel