netdev - Re: [PATCH net] net: openvswitch: fix TTL decrement action netlink message format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FBF56C40-90B7-4BAF-9AE3-B8304283E2D8@redhat.com>
Date:   Tue, 24 Nov 2020 11:51:40 +0100
From:   "Eelco Chaudron" <echaudro@...hat.com>
To:     "Pravin Shelar" <pravin.ovn@...il.com>
Cc:     "Linux Kernel Network Developers" <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "ovs dev" <dev@...nvswitch.org>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Bindiya Kurle" <bindiyakurle@...il.com>,
        "Ilya Maximets" <i.maximets@....org>, mcroce@...ux.microsoft.com
Subject: Re: [PATCH net] net: openvswitch: fix TTL decrement action netlink
 message format



On 20 Nov 2020, at 23:16, Pravin Shelar wrote:

> On Thu, Nov 19, 2020 at 1:04 AM Eelco Chaudron <echaudro@...hat.com> 
> wrote:
>>
>> Currently, the openvswitch module is not accepting the correctly 
>> formated
>> netlink message for the TTL decrement action. For both setting and 
>> getting
>> the dec_ttl action, the actions should be nested in the
>> OVS_DEC_TTL_ATTR_ACTION attribute as mentioned in the openvswitch.h 
>> uapi.
>>
>> Fixes: 744676e77720 ("openvswitch: add TTL decrement action")
>> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
> Thanks for working on this. can you share OVS kmod unit test for this 
> action?

Hi Pravin,

I did add a self-test, however, my previous plan was to send out the 
updated OVS patch after this change got accepted. But due to all the 
comments, I sent it out anyway, so here it is with a datapath test:

https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377795.html

//Eelco