netdev - Re: [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c8b77a9-f749-45ce-00d8-7695ac0f5855@mojatatu.com>
Date:   Tue, 24 Nov 2020 08:41:18 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Roi Dayan <roid@...dia.com>, David Ahern <dsahern@...il.com>,
        Zahari Doychev <zahari.doychev@...ux.com>,
        netdev@...r.kernel.org
Cc:     simon.horman@...ronome.com, jianbol@...lanox.com
Subject: Re: [PATCH iproute2-next v2] tc flower: use right ethertype in
 icmp/arp parsing

On 2020-11-24 7:13 a.m., Roi Dayan wrote:
> 
> 
> On 2020-11-24 11:39 AM, Roi Dayan wrote:
>>
>>

[..]
>> Hi,
>>
>> I didn't debug yet but with this commit I am failing to add a tc
>> rule I always could before. also the error msg doesn't make sense.
>>
>> Example:
>>
>> # tc filter add dev enp8s0f0 protocol 802.1Q parent ffff: prio 1 flower\
>>   skip_hw dst_mac e4:11:22:11:4a:51 src_mac e4:11:22:11:4a:50\
>>   vlan_ethtype 0x800 vlan_id 100 vlan_prio 0 action vlan pop action\
>>   mirred egress redirect dev enp8s0f0_0
>>
>>
>> Can't set "vlan_id" if ethertype isn't 802.1Q or 802.1AD
>>
>>
>> I used protocol 802.1Q and vlan_ethtype 0x800.
>> am i missing something? the rule should look different now?
>>
>> Thanks,
>> Roi
> 
> 
> Hi,
> 
> I debugged this and it break vlan rules.
> The issue is from this part of the change
> 

We have a test for this in tdc. Maybe we should make it a rule to
run tdc tests on changes like these?

cheers,
jamal