netdev - RE: [PATCH v4 6/6] igb: avoid transmit queue timeout in xdp path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Nov 2020 14:49:09 +0000
From:   "Penigalapati, Sandeep" <sandeep.penigalapati@...el.com>
To:     "sven.auhagen@...eatech.de" <sven.auhagen@...eatech.de>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "brouer@...hat.com" <brouer@...hat.com>,
        "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>
Subject: RE: [PATCH v4 6/6] igb: avoid transmit queue timeout in xdp path

From: sven.auhagen@...eatech.de <sven.auhagen@...eatech.de> 
Sent: Wednesday, November 11, 2020 10:35 PM
To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; kuba@...nel.org
Cc: davem@...emloft.net; intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com; Penigalapati, Sandeep <sandeep.penigalapati@...el.com>; brouer@...hat.com; pmenzel@...gen.mpg.de
Subject: [PATCH v4 6/6] igb: avoid transmit queue timeout in xdp path

From: Sven Auhagen <sven.auhagen@...eatech.de>

Since we share the transmit queue with the network stack, it is possible that we run into a transmit queue timeout.
This will reset the queue.
This happens under high load when XDP is using the transmit queue pretty much exclusively.

netdev_start_xmit() sets the trans_start variable of the transmit queue to jiffies which is later utilized by dev_watchdog(), so to avoid timeout, let stack know that XDP xmit happened by bumping the trans_start within XDP Tx routines to jiffies.

Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Signed-off-by: Sven Auhagen <sven.auhagen@...eatech.de>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 5 +++++
 1 file changed, 5 insertions(+)

Tested-by: Sandeep Penigalapati <sandeep.penigalapati@...el.com>