netdev - RE: [PATCH v4 1/4] ethtool: improve compat ioctl handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d1a587e7a9e4b65ac3a0c20554abdd3@AcuMS.aculab.com>
Date:   Tue, 24 Nov 2020 16:19:47 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Arnd Bergmann' <arnd@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Arnd Bergmann <arnd@...db.de>, Christoph Hellwig <hch@....de>
Subject: RE: [PATCH v4 1/4] ethtool: improve compat ioctl handling

From: Arnd Bergmann
> Sent: 24 November 2020 15:18
> 
> The ethtool compat ioctl handling is hidden away in net/socket.c,
> which introduces a couple of minor oddities:
> 
...
> +
> +static int ethtool_rxnfc_copy_from_compat(struct ethtool_rxnfc *rxnfc,
> +					  const struct compat_ethtool_rxnfc __user *useraddr,
> +					  size_t size)
> +{

I think this (and possibly others) want a 'noinline_for_stack'.
So that both the normal and compat structures aren't both on the
stack when the real code is called.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)