netdev - Re: [PATCH net-next] mptcp: be careful on MPTCP-level ack.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201124100809.08360e4c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 24 Nov 2020 10:08:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next] mptcp: be careful on MPTCP-level ack.

On Tue, 24 Nov 2020 12:20:11 +0100 Paolo Abeni wrote:
> -static void mptcp_send_ack(struct mptcp_sock *msk, bool force)
> +static inline bool tcp_can_send_ack(const struct sock *ssk)
> +{
> +	return !((1 << inet_sk_state_load(ssk)) &
> +	       (TCPF_SYN_SENT | TCPF_SYN_RECV | TCPF_TIME_WAIT | TCPF_CLOSE));
> +}

Does the compiler really not inline this trivial static function?