netdev - Re: [PATCH net-next 0/3] mvneta: access skb_shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201124143056.606fd5d0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 24 Nov 2020 14:30:56 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org,
        lorenzo.bianconi@...hat.com, davem@...emloft.net,
        brouer@...hat.com, echaudro@...hat.com, john.fastabend@...il.com,
        alexei.starovoitov@...il.com
Subject: Re: [PATCH net-next 0/3] mvneta: access skb_shared_info only on
 last frag

On Tue, 24 Nov 2020 23:25:11 +0100 Daniel Borkmann wrote:
> On 11/24/20 11:18 PM, Lorenzo Bianconi wrote:
> >> On Fri, 20 Nov 2020 18:05:41 +0100 Lorenzo Bianconi wrote:  
> >>> Build skb_shared_info on mvneta_rx_swbm stack and sync it to xdp_buff
> >>> skb_shared_info area only on the last fragment.
> >>> Avoid avoid unnecessary xdp_buff initialization in mvneta_rx_swbm routine.
> >>> This a preliminary series to complete xdp multi-buff in mvneta driver.  
> >>
> >> Looks fine, but since you need this for XDP multi-buff it should
> >> probably go via bpf-next, right?
> >>
> >> Reviewed-by: Jakub Kicinski <kuba@...nel.org>  
> > 
> > Hi Jakub,
> > 
> > thx for the review. Since the series changes networking-only bits I sent it for
> > net-next, but I agree bpf-next is better.
> > 
> > @Alexei, Daniel: is it fine to merge the series in bpf-next?  
> 
> Yeah totally fine, will take it into bpf-next in a bit.

FWIW watch out with the Link:s, it wasn't CCed to bpf@...r.