netdev - Re: netconsole deadlock with virtnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Nov 2020 14:20:17 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Leon Romanovsky <leon@...nel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Petr Mladek <pmladek@...e.com>,
        John Ogness <john.ogness@...utronix.de>,
        virtualization@...ts.linux-foundation.org,
        Amit Shah <amit@...nel.org>, Itay Aveksis <itayav@...dia.com>,
        Ran Rozenstein <ranro@...dia.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: netconsole deadlock with virtnet


On 2020/11/24 下午10:31, Steven Rostedt wrote:
> On Tue, 24 Nov 2020 11:22:03 +0800
> Jason Wang <jasowang@...hat.com> wrote:
>
>> Btw, have a quick search, there are several other drivers that uses tx
>> lock in the tx NAPI.
> tx NAPI is not the issue. The issue is that write_msg() (in netconsole.c)
> calls this polling logic with the target_list_lock held.


But in the tx NAPI poll it tries to lock TX instead of using trylock.


>
> Are those other drivers called by netconsole? If not, then this is unique
> to virtio-net.


I think the answer is yes, since net console is not disabled in the codes.

Thanks


>
> -- Steve
>