netdev - Re: [PATCH v2] net: mvpp2: divide fifo for dts-active ports only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201124150735.2f12b8c1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 24 Nov 2020 15:07:35 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     stefanc@...vell.com, netdev@...r.kernel.org,
        thomas.petazzoni@...tlin.com, davem@...emloft.net,
        nadavh@...vell.com, ymarkman@...vell.com,
        linux-kernel@...r.kernel.org, mw@...ihalf.com, andrew@...n.ch
Subject: Re: [PATCH v2] net: mvpp2: divide fifo for dts-active ports only

On Mon, 23 Nov 2020 20:17:15 +0000 Russell King - ARM Linux admin wrote:
> On Mon, Nov 23, 2020 at 07:54:33PM +0200, stefanc@...vell.com wrote:
> > From: Stefan Chulski <stefanc@...vell.com>
> > 
> > Tx/Rx FIFO is a HW resource limited by total size, but shared
> > by all ports of same CP110 and impacting port-performance.
> > Do not divide the FIFO for ports which are not enabled in DTS,
> > so active ports could have more FIFO.
> > No change in FIFO allocation if all 3 ports on the communication
> > processor enabled in DTS.
> > 
> > The active port mapping should be done in probe before FIFO-init.
> > 
> > Signed-off-by: Stefan Chulski <stefanc@...vell.com>  
> 
> Thanks.
> 
> Reviewed-by: Russell King <rmk+kernel@...linux.org.uk>
> 
> One thing I didn't point out is that netdev would like patch submissions
> to indicate which tree they are targetting. Are you intending this for
> net or net-next?
> 
> [PATCH net vX] ...
> 
> or
> 
> [PATCH net-next vX] ...
> 
> in the subject line please.

I'll assume Stefan does not know :) This patches does not appear to
fix a bug or other user-visible issue, so applying to net-next, it 
will be part of the next Linux release (5.11) and not queued to LTS.

Thanks!