[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJKOXPc1sBvuZACRM_4fjiSJECg7eRqWB+c2aQPDE1iPWHbdmA@mail.gmail.com>
Date: Wed, 25 Nov 2020 08:37:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bongsu Jeon <bongsu.jeon2@...il.com>
Cc: Bongsu Jeon <bongsu.jeon@...sung.com>,
"kuba@...nel.org" <kuba@...nel.org>,
"linux-nfc@...ts.01.org" <linux-nfc@...ts.01.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a
UART interface
On Wed, 25 Nov 2020 at 04:08, Bongsu Jeon <bongsu.jeon2@...il.com> wrote:
>
> On 11/24/20, krzk@...nel.org <krzk@...nel.org> wrote:
> > On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote:
> >> On Mon, Nov 23, 2020 at 5:02 PM krzk@...nel.org <krzk@...nel.org> wrote:
> >> >
> >> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote:
> > > > examples:
> >> > > - |
> >> > > #include <dt-bindings/gpio/gpio.h>
> >> > > @@ -71,3 +81,17 @@ examples:
> >> > > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
> >> > > };
> >> > > };
> >> > > + # UART example on Raspberry Pi
> >> > > + - |
> >> > > + &uart0 {
> >> > > + status = "okay";
> >> > > +
> >> > > + s3fwrn82_uart {
> >> >
> >> > Just "bluetooth" to follow Devicetree specification.
> >> Sorry. I don't understand this comment.
> >> Could you explain it?
> >> Does it mean i need to refer to the net/broadcom-bluetooth.txt?
> >
> > The node name should be "bluetooth", not "s3fwrn82_uart", because of
> > Devicetree naming convention - node names should represent generic class
> > of a device.
> >
> Actually, RN82 is the nfc device.
> So, is it okay to use the name as nfc instead of Bluetooth?
Oops, of course, nfc, I don't know why the Bluetooth stuck in my mind.
Best regards,
Krzysztof
Powered by blists - more mailing lists