netdev - Re: [PATCH net-next v2] net/nfc/nci: Support NCI 2.x initial sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201125073809.2116872e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 25 Nov 2020 07:38:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Bongsu Jeon <bongsu.jeon2@...il.com>
Cc:     Bongsu Jeon <bongsu.jeon@...sung.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linux-nfc@...ts.01.org
Subject: Re: [PATCH net-next v2] net/nfc/nci: Support NCI 2.x initial
 sequence

On Wed, 25 Nov 2020 21:33:48 +0900 Bongsu Jeon wrote:
> > > +     } else {
> > > +             /* if nci version is 2.0, then use the feature parameters */
> > > +             nci_send_cmd(ndev, NCI_OP_CORE_INIT_CMD, sizeof(struct nci_core_init_v2_cmd), cmd);  
> >
> > Please wrap this line.

This line is 100 characters long, prefer wrapping at 80 wherever
possible. Makes the code more readable (for me at least).